Under the bonnet changes

Posted by ,

I've been modifying the site's JavaScript lately and today have replaced all my long-winded hand-crafted code with more concise code using jQuery. Other than possibly pages being more responsive when they first load you shouldn't notice any difference but if you do see JavaScript errors popping up then do let me know via the contact form.

However, you no doubt will have noticed that I added a 'suggest' feature to the search box last week which hooks up the the database as you type and returns matches based on what you've typed so far. I'd be interested to know what you think of it: I've had some good feedback but also some negative. Is it a help or a hinderance?

9 comments on this article

Gravatar
By in United States,

The Search Bar with suggestions is very helpful because I can search a subtheme and go directly to it, instead of searching the main product and then clicking on the subtheme on the right.

But if some people don't like it, maybe on their profile they could have a button to turn it on or off.

Gravatar
By in United States,

I think it would be better if it didn't automatically select the top suggestion.

Gravatar
By in United States,

I've had good and bad experiences with it. I agree, there should be an ability to turn it off for those that don't like it.

Gravatar
By in Finland,

Thanks, again Huw :-) this feature is good.

Gravatar
By in United States,

I like it, but you should be able to turn it off (I agree, Forestmen).

Gravatar
By in Russian Federation,

My minifig collection future does not work !

Gravatar
By in Brazil,

The suggestions sure are helpful, but I also don't quite like the fact that the top suggestion is automatically selected. I think the best would to provide the drop down box with suggestions as the user types, but leaving the actual search box unaltered.

Oh, and I agree: there should be an off option for it.

Gravatar
By in United States,

Although the top item is selected it won't actually be used for the search unless you click on it. If you just type, say, Star Wars, then press Search the results will be as before: every set with 'Star Wars' in its theme, name, subtheme or set number.

Gravatar
By in United States,

Hmm. If you search by typing in the term and hitting Enter, it'll automatically select the top choice instead of what you've actually typed. Even if it's the right result (like if you type in a set #), the first Enter will fill in the search box with the top result and it takes a second Enter-ing to actually go to the search.

The workaround seems to be "type quickly and hit enter before the database can return any matches", but I'm not sure that's the best way to go about it.

For the record it's not that irritating, more just re-training ourselves to hit Enter twice instead of once.

Commenting has ended on this article.

Return to home page »